Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): add essentials to default features #1904

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Conversation

yash-atreya
Copy link
Member

@yash-atreya yash-atreya commented Jan 9, 2025

Motivation

Currently, the meta crate doesn't enable full feature by default which contains features that give access to the provider and contract API.

Solution

Added a new essentials feature and enabled it by default.

essentials = ["contract", "provider-http", "rpc-types", "signer-local"]

Note: Users that don't require all of the above, should use default-features = false and selectively add features to features = [] in their Cargo.toml.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@yash-atreya yash-atreya marked this pull request as draft January 9, 2025 14:26
@yash-atreya yash-atreya changed the title feat(meta): add full to default features feat(meta): add essentials to default features Jan 10, 2025
@yash-atreya yash-atreya marked this pull request as ready for review January 13, 2025 11:18
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol suggestion

crates/alloy/Cargo.toml Show resolved Hide resolved
@yash-atreya yash-atreya requested a review from mattsse January 14, 2025 07:49
@yash-atreya yash-atreya enabled auto-merge (squash) January 14, 2025 13:59
@mattsse mattsse disabled auto-merge January 15, 2025 01:17
@mattsse mattsse merged commit fac4979 into main Jan 15, 2025
26 checks passed
@mattsse mattsse deleted the yash/mk-full-default branch January 15, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants