feat: HashBuilder::add_leaf_unchecked
#64
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're stress-testing live state root calculation in Reth that led back to this crate (thanks for the great work!).
So, this
assert
takes ~7.7% ofHashBuilder::add_leaf
and ~1% ofStateRoot::calculate
:trie/src/hash_builder/mod.rs
Lines 113 to 114 in 25c252f
This PR adds an
unchecked
version for performance-critical users who guarantee keys are added in sorted order (like Reth with its node iterator).