Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(allure-jest): Add ability to assign custom names for any attachments (feat #801) #819

Merged
merged 3 commits into from
Dec 13, 2023
Merged

feat(allure-jest): Add ability to assign custom names for any attachments (feat #801) #819

merged 3 commits into from
Dec 13, 2023

Conversation

Louis-Wu-Sea
Copy link
Contributor

Context

Add ability to assign custom names for any attachments #801

Checklist

@CLAassistant
Copy link

CLAassistant commented Dec 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added theme:api Javascript API related issue theme:jest Jest related issue labels Dec 13, 2023
@Louis-Wu-Sea Louis-Wu-Sea reopened this Dec 13, 2023
@Louis-Wu-Sea Louis-Wu-Sea force-pushed the feat/name-for-attachments branch from 510307e to 806fa98 Compare December 13, 2023 02:02
@Louis-Wu-Sea Louis-Wu-Sea reopened this Dec 13, 2023
@Louis-Wu-Sea Louis-Wu-Sea mentioned this pull request Dec 13, 2023
Closed
@Louis-Wu-Sea Louis-Wu-Sea reopened this Dec 13, 2023
@Louis-Wu-Sea Louis-Wu-Sea force-pushed the feat/name-for-attachments branch from 6cbc2af to 3d67d1c Compare December 13, 2023 03:18
epszaw
epszaw requested changes Dec 13, 2023
View reviewed changes
Copy link
Member

@epszaw epszaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job there! Please fix some moments I've highlighted in the review to continue

packages/allure-jest/src/AllureJestApi.ts Outdated Show resolved Hide resolved
packages/allure-jest/test/fixtures/attachments.test.js Outdated Show resolved Hide resolved
@epszaw epszaw added the type:new feature New feature or request label Dec 13, 2023
@Louis-Wu-Sea Louis-Wu-Sea force-pushed the feat/name-for-attachments branch from 9ef7b81 to f14b6c5 Compare December 13, 2023 13:30
@Louis-Wu-Sea
Copy link
Contributor Author

@baev @epszaw I have extended the "attachment" method for jest only. Do I need to add for other frameworks?

@baev baev changed the title feat: Add ability to assign custom names for any attachments (feat #801) feat(allure-jest): Add ability to assign custom names for any attachments (feat #801) Dec 13, 2023
@baev
Copy link
Member

baev commented Dec 13, 2023

@Louis-Wu-Sea, it would be nice. We can do other integrations in separate PR since some may be not that straightforward.

@baev baev merged commit 16e943f into allure-framework:master Dec 13, 2023
7 checks passed
@baev
Copy link
Member

baev commented Dec 13, 2023

@Louis-Wu-Sea thanks

@Louis-Wu-Sea
Copy link
Contributor Author

@baev @epszaw How often do you release packages? So I know when I can use it?

@baev
Copy link
Member

baev commented Dec 13, 2023

I'll try to release it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epszaw epszaw epszaw approved these changes

@baev baev baev approved these changes

Assignees
No one assigned
Labels
theme:api Javascript API related issue theme:jest Jest related issue type:new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Louis-Wu-Sea @CLAassistant @baev @epszaw