-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allure step in thread (fixes #563) #605
Allure step in thread (fixes #563) #605
Conversation
@nigredon1991 |
Now step correct showing in Thread
2179ac3
to
138ff49
Compare
If I understand correctly, then to launch I need an approval from maintainers. |
Check for example this pull request: Do you have actions enabled for your repo? |
Thank you. Otherwise I didn’t think of it. |
threading.get_native_id() -> threading.get_ident()
Looks like you still need write at least one test for this case |
Tests added. |
So now we need to summon maintainer :) @sseliverstov Can you please review this PR? |
Great job! Unfortunately, I can review it right now. I going to do it next week. Feel free to summon me again. |
@sseliverstov so... new week now |
Someone, please review and merge this. It is a long waiting PR/Change. |
@sseliverstov, can you review this PR? :) |
Maybe I need to do something else so that can merge? |
@sseliverstov any feedback? |
Maybe I need to do something else so that can merge? |
Test for example with thread:
Without this request allure report looks like this:
And with this request report looks like this:
In the request, the generation of the report has been corrected if threads are created during the launch process. Each step now remembers its parent, even if it was launched in a thread.
Context
Fix for #563
Checklist