Add data_hygiene:discard_drafts_and_unpublish #3081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KludgeKML
force-pushed
the
unpublish-robots-txt
branch
from
567f92d to
6d56124
Compare
KludgeKML
changed the title
- takes a content_id and unpublishes that with a 410 Gone, discarding drafts if necessary. - Immediate use is to unpublish robots.txt, which is now handled entirely within nginx, so has an unnecessary special route.
KludgeKML
force-pushed
the
unpublish-robots-txt
branch
from
6d56124 to
1cda20f
Compare
brucebolt
reviewed
Jan 14, 2025
|
|
||
| desc "Discard drafts (if present) and unpublish" | ||
| task :discard_drafts_and_unpublish, %i[content_id] => :environment do |_, args| | ||
| document = Document.where(content_id: args[:content_id]).first |
There was a problem hiding this comment.
You could get multiple documents returned here, since the same content ID is used for multiple locales.
I'd recommend returning all of them, then looping through to discard the drafts and unpublish each one.
There was a problem hiding this comment.
How does the unpublish work with locales? It's not clear to me how to pass a document object to Commands::V2::Unpublish (the examples I can find either pass in a content id, which obviously doesn't help, or an edition). Do I discard all the drafts and then pass in the Document's latest edition?
There was a problem hiding this comment.
The discard and unpublish commands can both take a locale as an argument (example).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.