Dmic nhlt update #254
Closed
Dmic nhlt update #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error if the version passed from topology is not known. Also fix the dmic_set_params() error prints for to show the correct function name. Signed-off-by: Seppo Ingalsuo <[email protected]> Signed-off-by: Jyri Sarha <[email protected]>
The former Burst Fifo ThresHold bits 20-23 in output register are specified as reserved bits starting from driver version 4. Signed-off-by: Seppo Ingalsuo <[email protected]> Signed-off-by: Jyri Sarha <[email protected]>
Many error prints had obsolete function name written in them, use __func__ everywhere and add problematic value to the print if its available. Signed-off-by: Jyri Sarha <[email protected]>
|
@singalsu , the PR is here. Please let me know when we are ready to mark this "Ready for review". |
plbossart
reviewed
Mar 5, 2024
| @@ -781,7 +781,10 @@ static int configure_registers(struct intel_dmic_params *dmic, struct dmic_calc_ | |||
| } | |||
| } | |||
|
|
|||
| if (dmic->dmic_prm[di].driver_version == 2 || dmic->dmic_prm[di].driver_version == 3) { | |||
| if (dmic->dmic_prm[di].driver_version >= 2) { | |||
| if (dmic->dmic_prm[di].driver_version >= 4) | |||
There was a problem hiding this comment.
is this saying that driver_version 4 and 5 are identical? I didn't see any other place where version 5 was checked, but it's allowed in the first patch.
There was a problem hiding this comment.
For now 4 and 5 are identical. If we need to enable new features of platform "5" there will be later more changes.
plbossart
approved these changes
Mar 6, 2024
singalsu
approved these changes
Mar 8, 2024
|
@perexg , I think this should be ready for merging. |
perexg
pushed a commit
that referenced
this pull request
Mar 16, 2024
The former Burst Fifo ThresHold bits 20-23 in output register are specified as reserved bits starting from driver version 4. Closes: #254 Signed-off-by: Seppo Ingalsuo <[email protected]> Signed-off-by: Jyri Sarha <[email protected]> Signed-off-by: Jaroslav Kysela <[email protected]>
perexg
pushed a commit
that referenced
this pull request
Mar 16, 2024
Many error prints had obsolete function name written in them, use __func__ everywhere and add problematic value to the print if its available. Closes: #254 Signed-off-by: Jyri Sarha <[email protected]> Signed-off-by: Jaroslav Kysela <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driver version 4 update from for DMIC NHLT generator, and some error print improvements.