Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeouts to DeepSpace GRPC methods #28

Open
jkilpatr opened this issue Mar 26, 2024 · 0 comments
Open

Add timeouts to DeepSpace GRPC methods #28

jkilpatr opened this issue Mar 26, 2024 · 0 comments
Assignees

Comments

@jkilpatr
Copy link
Member

While the contact struct defines a user desired timeout it's not actually ever used anywhere in the code.

Meaning when we make a grpc connection to a server it's actually subject to the system tcp socket timeout of a couple of hours.

Behavior wise this is very bad in Rita where payment_validator currently tries to call the althea payment validation code for every incoming payment, at which point the code will hang for a few hours before moving on since there is no server on the other end of that rpc url (we just moved it) and there is also no shorter timeout set.

In order to resolve this issue every grpc connect, request, and send method needs to use the tokio timeout routine. Example in the top comment on this branch https://github.com/althea-net/deep_space/tree/jkilpatr/add_timeouts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants