Jkilpatr/add timeouts #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue details: While the contact struct defines a user desired timeout it's not actually ever used anywhere in the code. Meaning when we make a grpc connection to a server it's actually subject to the system tcp socket timeout of a couple of hours. Behavior wise this is very bad in Rita where payment_validator currently tries to call the althea payment validation code for every incoming payment, at which point the code will hang for a few hours before moving on since there is no server on the other end of that rpc url (we just moved it) and there is also no shorter timeout set. In order to resolve this issue every grpc connect, request, and send method needs to use the tokio timeout routine.
jkilpatr
force-pushed
the
jkilpatr/add_timeouts
branch
from
a6c98e8 to
8673442
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #28 resolution