Fix wifi data gathering #1080
Open
Fix wifi data gathering #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #1078 |
ch-iara
force-pushed
the
chiara/refix-wifi-data-gathering-mast
branch
2 times, most recently
from
6d62c60 to
39a14f0
Compare
This fix adds on to 58c0626 which fixed the missing wifi device data with the unintended side effect of breaking the ability to set wifi settings from ops. The original problem was that for routers missing the ifname setting in /etc/config/wireless, the wifi interface names differ between uci and iw, the two places we gather different wifi info to be sent over in the WifiDevice field of HardwareInfo. The first fix used iw instead to gather interface names, but since ifnames may differ between the two systems if routers are missing the config line, this broke wifi settings when routers were searching uci for an interface name only used by iw. This change calls both uci and iw so no matter whether the router has its ifname nicknamed it can gather the required data to be sent to ops for each interface.
ch-iara
force-pushed
the
chiara/refix-wifi-data-gathering-mast
branch
from
39a14f0 to
8161cde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix adds on to 58c0626 which fixed the missing wifi device data with the unintended side effect of breaking the ability to set wifi settings from ops. The original problem was that for routers missing the ifname setting in /etc/config/wireless, the wifi interface names differ between uci and iw, the two places we gather different wifi info to be sent over in the WifiDevice field of HardwareInfo. The first fix used iw instead to gather interface names, but since ifnames may differ between the two systems if routers are missing the config line, this broke wifi settings when routers were searching uci for an interface name only used by iw.
This change calls both uci and iw so no matter whether the router has its ifname nicknamed it can gather the required data to be sent to ops for each interface.