Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create only a single FFI, with one call to verify(). #5

Open
wants to merge 1 commit into
base: cffi
Choose a base branch
from
Open

Create only a single FFI, with one call to verify(). #5

wants to merge 1 commit into from

Conversation

arigo
Copy link

@arigo arigo commented Nov 18, 2014

This calls ffi.verify() only once, and avoids calls to ffi.include().

@arigo
Copy link
Author

arigo commented Nov 18, 2014

Note that running all tests with "test.py" hangs after a while for me (at the same place before and after my commit), so that I could only check in part that I really didn't break anything.

@mithrandi
Copy link

This change is now merged into https://github.com/lxml-cffi/lxml-cffi (in preparation for switching to the new set_source API); the test failure/hang is still there, unfortunately.

EDIT: The tests are passing on lxml-cffi now, for any lost souls that landed up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants