chore: enable ubsan and asan in debug build script #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadderchris
force-pushed
the
enable-sanitizers
branch
3 times, most recently
from
7b49c17 to
b782e77
Compare
sadderchris
force-pushed
the
enable-sanitizers
branch
from
b782e77 to
7a384ac
Compare
tgregg
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #283
Description of changes:
This turns on the ubsan and asan sanitizers for debug builds on macos and ubuntu in the CI pipeline. This doesn't cause any build failures currently, but it does spit out stack traces for places where undefined behavior and memory safety issues are present.
This also makes debug builds slightly faster by tuning the number of jobs make uses to the number of cpu cores available.
Work still needs to be done to enable these on AL1/2 and windows.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.