Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create destination directory during symlink install #569

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Create destination directory during symlink install #569

merged 1 commit into from
Jan 16, 2025

Conversation

EzraBrooks
Copy link
Contributor

@EzraBrooks EzraBrooks commented Dec 30, 2024 •
edited
Loading

Minimal fix for #568.

As I wrote in the comment, this doesn't fix the issue of recursive directory trees that might contain empty folders, but it does at least create the directory that the user specified in their invocation of install(), which is what my specific issue was.

@EzraBrooks EzraBrooks force-pushed the fix-missing-directories-in-symlink-install branch from 59d5730 to d6143ac Compare December 30, 2024 20:53
@cottsay
Copy link
Contributor

cottsay commented Jan 15, 2025

CI without --symlink-install:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

CI with --symlink-install:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

cottsay
cottsay approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making a PR.

I think a complete fix would involve changing both of the GLOB_RECURSE calls below to include directories in their matches and then teasing them apart later, which could be expensive.

This change is much lower effect and lower risk.

@cottsay cottsay linked an issue Jan 16, 2025 that may be closed by this pull request
Symlink installs do not copy empty directories #568
Closed
@cottsay cottsay added the bug Something isn't working label Jan 16, 2025
@cottsay cottsay merged commit 1b66f6c into ament:rolling Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cottsay cottsay cottsay approved these changes

Assignees

@cottsay cottsay

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symlink installs do not copy empty directories
2 participants
@EzraBrooks @cottsay