Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jax.block_until_ready in benchmarks #344

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

xela-95
Copy link
Member

@xela-95 xela-95 commented Jan 15, 2025

In this PR I added two little changes:


📚 Documentation preview 📚: https://jaxsim--344.org.readthedocs.build//344/

@xela-95 xela-95 self-assigned this Jan 15, 2025
@xela-95 xela-95 requested a review from flferretti as a code owner January 15, 2025 16:56
Copy link
Collaborator

@flferretti flferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @xela-95, this was very much needed! LGTM

Before merging, would you mind updating the PR title to be more specific to the changes, like "Use jax.block_until_ready in benchmarks" or something related to avoid measuring the dispatch? Thank you

@xela-95 xela-95 changed the title Update benchmark tests Use jax.block_until_ready in benchmarks Jan 15, 2025
@xela-95
Copy link
Member Author

xela-95 commented Jan 15, 2025

Thanks a lot @xela-95, this was very much needed! LGTM

Before merging, would you mind updating the PR title to be more specific to the changes, like "Use jax.block_until_ready in benchmarks" or something related to avoid measuring the dispatch? Thank you

Done! Rebasing and merging then :)

@xela-95 xela-95 force-pushed the test/benchmark-patch branch from 476b723 to 709ceed Compare January 15, 2025 20:15
@xela-95 xela-95 enabled auto-merge January 15, 2025 20:16
@xela-95 xela-95 merged commit b9eadd3 into ami-iit:main Jan 15, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants