-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nextcloud Thumbnails #166
Closed
Closed
Nextcloud Thumbnails #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Single stream upload file - Removed redundant ftp helper functions
- SMB client work in-progress
Bugfix: WebDAV searchFiles "including" param was being ignored
…cate FTPS server > define an enum like Alamofire's ServerTrustPolicy
Fixed Issue #127: Support for connect to self-signed certificate FTPS server
- missing `return`
- change redundant `ftpUserPass` to `completionHandler`
Fixed bug in FTP data-connection and login
Fixed Issue#111: Connection stays open after FTP upload
- Break a readData looping when the end of the stream has been reached
Fixed a blocked stream handle event during UI control
Fixed Issue#113: FTP timeout error occurred when ftpList an empty directory
Fixed few bug on FTP
- Get a SessionID of control connection after TLS Handshake, and set the SessionID to data connection
Added FTP SSL/TLS session resumption/reuse support
Fixed bug: cannot be transferred file 4KB or less
squirtla83
approved these changes
Dec 2, 2020
squirtla83
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement support for getting thumbnails from Nextcloud (and maybe OwnCloud. I haven't tested it).
Nextcloud WebDAV access is done through
remote.php/dav/files/
while thumbnails are accessed throughindex.php/core/preview.png
, so by checking if thebaseURL
containsremote.php/dav/files/
we can know if it's a Nextcloud server. If it is, we can replace that with the preview URL.Also has a minor fix for the existing yandex thumbnail support where file extensions were checked case-sensitively.
Closes #165