Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hwmon: (pmbus/lt3074) add support for lt3074 #2685

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cencarna
Copy link

@cencarna cencarna commented Jan 7, 2025

PR Description

This adds hardware monitoring and regulator support for Analog Devices LT3074.
The LT3074 is an ultralow noise, ultrafast, 3A, 5.5V dropout linear regulator with
PMBus serial interface which features telemetry for input/output voltage, bias
voltage, output current, and die temperature.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly (if there is the case)

Copy link
Collaborator

@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor notes. Please sent this upstream

drivers/hwmon/pmbus/lt3074.c Outdated Show resolved Hide resolved
drivers/hwmon/pmbus/lt3074.c Outdated Show resolved Hide resolved
drivers/hwmon/pmbus/lt3074.c Outdated Show resolved Hide resolved
drivers/hwmon/pmbus/lt3074.c Outdated Show resolved Hide resolved
drivers/hwmon/pmbus/lt3074.c Show resolved Hide resolved
drivers/hwmon/pmbus/lt3074.c Outdated Show resolved Hide resolved
Add Analog Devices LT3074 Ultralow Noise, High PSRR Dropout Linear
Regulator.

Signed-off-by: Cedric Encarnacion <[email protected]>
Add hardware monitoring and regulator support for LT3074. The LT3074 is an
ultrafast, ultralow noise 3A, 5.5V dropout linear regulator. The PMBus
serial interface allows telemetry for input/output voltage, bias voltage,
output current, and die temperature.

Signed-off-by: Cedric Encarnacion <[email protected]>
Add entries for lt3074 driver.

Signed-off-by: Cedric Encarnacion <[email protected]>
@cencarna
Copy link
Author

v2

  • Removed extra lines
  • return immediately for all cases in write_word_data and read_word_data
  • Used __maybe_unused
  • Used dev_err_probe and add extra error handling for failed read transactions (ret < 0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants