Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an AST visitor module and refactor the code generation to use it. #70

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jvprat
Copy link
Contributor

@jvprat jvprat commented Apr 29, 2016

This allows code reuse when navigating the AST, and it allows new modules that handle a few node types to be much smaller and simpler (I'm working on a new module).
In addition, the code generation and the checker are updated to use it, and some funcionts are split into smaller functions that handle concrete node types.

@jvprat jvprat force-pushed the visitor branch 4 times, most recently from 26f5395 to 01dfe46 Compare May 3, 2016 16:15
@jvprat jvprat force-pushed the visitor branch 3 times, most recently from ef86fc3 to a740d25 Compare May 12, 2016 17:20
@mascarenhas
Copy link
Collaborator

It seems like the visitor module's default visitor would make it simpler to implement visitors that only need to act on specific AST nodes, correct? Could you do a new pull request with just the visitor module, without converting the existing code generator and type checker? Thanks!

@andremm
Copy link
Owner

andremm commented Nov 13, 2017

@mascarenhas can we close this after merging PR #115 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants