Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry Pick] Use one NavHost (with a single navigation scaffold) (#102) #114

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

ashnohe
Copy link
Contributor

@ashnohe ashnohe commented Dec 11, 2024

  • Deduplicate lifecycle runtime compose

  • kotlin 2.0 and compose gradle plugin

  • update test & other versions

  • Call navigate instead of recomposing HavHost

Previously, the app had a NavHost but didn't actually call navigate. NavHost's startDestination was read from external state (the currently selected nav item), which led to some undesirable behaviors.

  • NavHost itself was recomposed when selecting a nav item.
  • Pressing back always exited the app because you were always at the start destination.

Now the NavHost has a stable startDestination, and nav item state is driven by the NavHostController's current destination. Selecting a nav item calls navigate, and the user always goes back through the startDestination before exiting the app.

  • Use type-safe navigation

  • Make a package for navigation routes

  • Migrate to type safe routes for main navhost

  • Push Scaffold down to each top-level destination

  • Extract nav suite scaffold to another composable

  • Move ChatList, move and rename HomeViewModel

  • Move Settings to its own package

  • Remove Home and put its destinations in Main NavHost

  • Remove Home composable and rename file

  • Add NavigationSuiteScaffold around NavHost

  • Change navigation layout type based on current destination

* Deduplicate lifecycle runtime compose

* kotlin 2.0 and compose gradle plugin

* update test & other versions

* Call navigate instead of recomposing HavHost

Previously, the app had a NavHost but didn't actually call navigate.
NavHost's startDestination was read from external state (the currently
selected nav item), which led to some undesirable behaviors.
- NavHost itself was recomposed when selecting a nav item.
- Pressing back always exited the app because you were always at the
  start destination.

Now the NavHost has a stable startDestination, and nav item state is
driven by the NavHostController's current destination. Selecting a nav
item calls navigate, and the user always goes back through the
startDestination before exiting the app.

* Use type-safe navigation

* Make a package for navigation routes

* Migrate to type safe routes for main navhost

* Push Scaffold down to each top-level destination

* Extract nav suite scaffold to another composable

* Move ChatList, move and rename HomeViewModel

* Move Settings to its own package

* Remove Home and put its destinations in Main NavHost

* Remove Home composable and rename file

* Add NavigationSuiteScaffold around NavHost

* Change navigation layout type based on current destination
Copy link
Contributor

@mlykotom mlykotom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed 2 LoC -- moved a viewmodel retrieval to the composable parameter.

@mlykotom mlykotom merged commit a506e60 into main Dec 12, 2024
1 check passed
@ashnohe ashnohe deleted the onenavhost branch December 12, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants