Glance Widget WIP #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arriolac
reviewed
Mar 20, 2024
app/src/main/java/com/google/android/samples/socialite/widget/SocialiteWidgetReceiver.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/google/android/samples/socialite/SocialApp.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/google/android/samples/socialite/ui/chat/ChatViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/google/android/samples/socialite/widget/SocialiteWidgetReceiver.kt
Outdated
Show resolved
Hide resolved
yaraki
reviewed
Mar 21, 2024
app/src/main/java/com/google/android/samples/socialite/data/AppDatabase.kt
Outdated
Show resolved
Hide resolved
|
Hey guys I've done some updates. I've collapsed the PR down to two commits. The first is the "base" to be cherry picked for the codelab starter and the second is the solution for the codelab |
secondsun
force-pushed
the
io24_widget
branch
2 times, most recently
from
c39c8cd to
83a0fa4
Compare
Regress SociaLite by removing predictive back support for I/O'24 codelab
secondsun
force-pushed
the
io24_widget
branch
5 times, most recently
from
2c2637c to
c2852dd
Compare
arriolac
reviewed
Apr 1, 2024
app/src/main/java/com/google/android/samples/socialite/widget/ui/ContactRow.kt
Outdated
Show resolved
Hide resolved
| import com.google.android.samples.socialite.widget.model.WidgetModel | ||
|
|
||
| @Composable | ||
| fun FavoriteContact(model: WidgetModel, onClick: Action) { |
There was a problem hiding this comment.
Same here - this should accept a modifier
| import kotlinx.coroutines.runBlocking | ||
|
|
||
| @Composable | ||
| fun ZeroState(repository: WidgetModelRepository, widgetId: Int, context: Context) { |
There was a problem hiding this comment.
Can you get the context from LocalContext rather than having to pass it here as an argument?
This should also accept a modifier.
yaraki
approved these changes
Apr 2, 2024
| @@ -0,0 +1,9 @@ | |||
| <appwidget-provider xmlns:android="http://schemas.android.com/apk/res/android" | |||
Change-Id: Ibba72892121de5f6b30f951857cb5760a4449f54
Change-Id: Ibba72892121de5f6b30f951857cb5760a4449f54
Change-Id: Ie75625aa5ca568f41f94ef58b98a583c79aebe0d
Change-Id: I9536635d414af6fad22ebc79ef8d400810b9ffb4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first draft / MVP of a widget for SociaLite built with Glance.