-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using CameraX's camera-viewfinder-compose module. #58
Conversation
@SigmanZero @madebymozart Hoping to get this reviewed and merged today. Thanks! Will be creating a separate branch for demo purposes after this is merged. |
Some observations from testing on a Pixel Fold:
|
The goal of setting the target rotation on the ImageCapture and VideoCapture use cases can be accomplished without restarting the preview, which cause a visual glitch on the preview stream.
Thanks for the feedback, @SigmanZero!
|
Thank you! I think this PR LGTM now - I'll open a separate issue for item 3, I was able to repro on my Pixel Fold and got a screen recording + bug report, but I'm able to capture the front-facing picture on a Galaxy S24 Ultra. |
This updates to the new CameraX camera-viewfinder-compose module.
Note: this module hasn't landed in a CameraX version yet, so we have to depend on the SNAPSHOT version. A future PR will fix this when the module reaches an alpha release.
The prototype of camera-viewfinder-compose was copied under
/app/src/main/java/com/google/android/samples/socialite/ui/camera/viewfinder/
, which is also removed in this PR.