clean code

anggastudio · Oct 8, 2020 · b572c0c · b572c0c
1 parent 560adb9
commit b572c0c
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 8 deletions.
diff --git a/app/src/main/java/com/anggastudio/sample/MainActivity.java b/app/src/main/java/com/anggastudio/sample/MainActivity.java
@@ -49,15 +49,17 @@ private void getSavedPrinter() {
         BluetoothDevice connectedPrinter = Printama.with(this).getConnectedPrinter();
         if (connectedPrinter != null) {
             TextView connectedTo = findViewById(R.id.tv_printer_info);
-            connectedTo.setText("Connected to : " + connectedPrinter.getName());
+            String text = "Connected to : " + connectedPrinter.getName();
+            connectedTo.setText(text);
         }
     }
 
     private void showPrinterList() {
         Printama.showPrinterList(this, printerName -> {
             Toast.makeText(this, printerName, Toast.LENGTH_SHORT).show();
             TextView connectedTo = findViewById(R.id.tv_printer_info);
-            connectedTo.setText("Connected to : " + printerName);
+            String text = "Connected to : " + printerName;
+            connectedTo.setText(text);
             if (!printerName.contains("failed")) {
                 findViewById(R.id.btn_printer_test).setVisibility(View.VISIBLE);
                 findViewById(R.id.btn_printer_test).setOnClickListener(v -> testPrinter());
@@ -81,7 +83,8 @@ private void printTextLeft() {
                 "------------------\n";
         Printama.with(this).connect(printama -> {
             printama.printText(Printama.LEFT, text);
-            // or simply printama.printText("some text") --> will be printed left aligned as default
+            // or simply
+            // printama.printText("some text") --> will be printed left aligned as default
             printama.close();
         });
     }
@@ -241,9 +244,7 @@ private void printQrReceipt() {
         PrintBody body = printModel.getPrintBody();
         PrintFooter footer = printModel.getPrintFooter();
         String date = "DATE: " + body.getDate();
-        String time = "PRINT TIME " + body.getTime();
         String invoice = "INVOICE: " + body.getInvoice();
-        String midwareTimestamp = "CREATE TIME: " + body.getTimeStamp();
 
         Printama.with(this).connect(printama -> {
             printama.printImage(logo, 300);
@@ -288,7 +289,8 @@ protected void onActivityResult(int requestCode, int resultCode, @Nullable Inten
     private void showResult(String printerName) {
         showToast(printerName);
         TextView connectedTo = findViewById(R.id.tv_printer_info);
-        connectedTo.setText("Connected to : " + printerName);
+        String text = "Connected to : " + printerName;
+        connectedTo.setText(text);
         if (!printerName.contains("failed")) {
             findViewById(R.id.btn_printer_test).setVisibility(View.VISIBLE);
             findViewById(R.id.btn_printer_test).setOnClickListener(v -> testPrinter());

diff --git a/app/src/main/java/com/anggastudio/sample/model/PrintBody.java b/app/src/main/java/com/anggastudio/sample/model/PrintBody.java
@@ -1,7 +1,5 @@
 package com.anggastudio.sample.model;
 
-import android.graphics.Bitmap;
-
 public class PrintBody {
     String invoice;
     String date;

diff --git a/app/src/main/java/com/anggastudio/sample/model/PrintFooter.java b/app/src/main/java/com/anggastudio/sample/model/PrintFooter.java
@@ -16,6 +16,7 @@ public String getInitial() {
     public void setInitial(String initial) {
         this.initial = initial;
     }
+
     public String getPaymentBy() {
         return paymentBy;
     }

diff --git a/app/src/main/java/com/anggastudio/sample/util/Util.java b/app/src/main/java/com/anggastudio/sample/util/Util.java
@@ -8,12 +8,18 @@
 
 public class Util {
 
+    private Util() {
+
+    }
+
     public static Bitmap decodeBase64(String base64) {
         byte[] decodedByte = Base64.decode(base64, 0);
         return BitmapFactory.decodeByteArray(decodedByte, 0, decodedByte.length);
     }
 
     public static Bitmap getQrCode(String qrCode) {
+        // please see the dependencies to create QRCode
+        // it's not included in Printama
         return QRCode.from(qrCode).bitmap();
     }