Skip to content

Commit

Permalink
fix reputation cmds issue (demisto#35944) (demisto#36119)
Browse files Browse the repository at this point in the history
* fix reputation cmds issue

* add ignore validation for file EclecticIQIntelligenceCenterv3.yml

* fix typo in tests

* version bump

* Fix ignore format.

---------

Co-authored-by: chloerongier <[email protected]>
Co-authored-by: Danny_Fried <[email protected]>
  • Loading branch information
3 people authored Sep 3, 2024
1 parent e5cfca8 commit ce836f7
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 10 deletions.
2 changes: 1 addition & 1 deletion Packs/EclecticIQ/.pack-ignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
ignore=IN144

[file:EclecticIQIntelligenceCenterv3.yml]
ignore=IN122
ignore=IN144,IN122
Original file line number Diff line number Diff line change
Expand Up @@ -1786,10 +1786,10 @@ def parse_reputation_results(

else:
human_readable = (
"### Observable: " + str(observable_value) + " not found in EcelcticIQ IC."
"### Observable: " + str(observable_value) + " not found in EclecticIQ IC."
)
raw_result = {
"result": "Observable not found in EcelcticIQ IC.",
"result": "Observable not found in EclecticIQ IC.",
"observable": str(observable_value),
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ script:
description: IPv4 to get the reputation of.
name: ip
required: true
isArray: true
isArray: false
description: Get reputation of IP address observable.
name: ip
outputs:
Expand Down Expand Up @@ -221,7 +221,7 @@ script:
description: URL observable to get the reputation of.
name: url
required: true
isArray: true
isArray: false
description: Gets the reputation of a URL observable.
name: url
outputs:
Expand Down Expand Up @@ -263,7 +263,7 @@ script:
description: File hash observable to get the reputation of.
name: file
required: true
isArray: true
isArray: false
description: Gets the reputation of a file hash observable.
name: file
outputs:
Expand Down Expand Up @@ -383,7 +383,7 @@ script:
- default: true
description: Email address observable to get the reputation of.
name: email
isArray: true
isArray: false
required: true
description: Gets the reputation of an email address observable.
name: email
Expand Down Expand Up @@ -422,7 +422,7 @@ script:
- default: true
description: Domain observable to get the reputation of.
name: domain
isArray: true
isArray: false
required: true
description: Gets the reputation of a domain observable.
name: domain
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ def test_parse_reputation_results(mocker):

def test_parse_reputation_results_empty_reply(mocker):
response = parse_reputation_results(None, "test.com", "domain", "low", "Domain")
assert response[0].raw_response["result"] == 'Observable not found in EcelcticIQ IC.'
assert response[0].raw_response["result"] == 'Observable not found in EclecticIQ IC.'


def test_domain_command(mocker):
Expand Down
5 changes: 5 additions & 0 deletions Packs/EclecticIQ/ReleaseNotes/3_0_4.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
#### Integrations

##### EclecticIQ Intelligence Center v3
- Fixed the commands **ip**, **url**, **domain**, **file** and **email** that would not handle an array as argument.
- Fixed a typo in commands' output.
2 changes: 1 addition & 1 deletion Packs/EclecticIQ/pack_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "EclecticIQ Platform",
"description": "Threat Intelligence Platform that connects and interprets intelligence data from open sources, commercial suppliers and industry partnerships.",
"support": "partner",
"currentVersion": "3.0.3",
"currentVersion": "3.0.4",
"author": "EclecticIQ",
"url": "https://support.eclecticiq.com",
"email": "[email protected]",
Expand Down

0 comments on commit ce836f7

Please sign in to comment.