This repository has been archived by the owner on Oct 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
force-pushed
the
chore/nvm-to-asdf
branch
from
January 23, 2024 17:51
304087f
to
d3f03b5
Compare
ssbarnea
force-pushed
the
chore/nvm-to-asdf
branch
from
January 23, 2024 18:21
d3f03b5
to
7036507
Compare
ssbarnea
force-pushed
the
chore/nvm-to-asdf
branch
from
January 23, 2024 18:37
7036507
to
b67a639
Compare
ssbarnea
force-pushed
the
chore/nvm-to-asdf
branch
from
January 23, 2024 18:58
b67a639
to
35ebd97
Compare
ssbarnea
force-pushed
the
chore/nvm-to-asdf
branch
from
January 23, 2024 20:42
35ebd97
to
d1cb1f1
Compare
ssbarnea
force-pushed
the
chore/nvm-to-asdf
branch
from
January 23, 2024 20:51
d1cb1f1
to
31ee447
Compare
ssbarnea
force-pushed
the
chore/nvm-to-asdf
branch
from
January 23, 2024 21:34
31ee447
to
a2dbb60
Compare
ssbarnea
force-pushed
the
chore/nvm-to-asdf
branch
from
January 23, 2024 21:37
a2dbb60
to
f60e793
Compare
ssbarnea
force-pushed
the
chore/nvm-to-asdf
branch
from
January 23, 2024 21:48
f60e793
to
00eb5ab
Compare
ssbarnea
force-pushed
the
chore/nvm-to-asdf
branch
from
January 23, 2024 21:55
00eb5ab
to
e23c5d6
Compare
ssbarnea
force-pushed
the
chore/nvm-to-asdf
branch
from
January 23, 2024 21:59
e23c5d6
to
2d82c8f
Compare
ssbarnea
force-pushed
the
chore/nvm-to-asdf
branch
from
January 23, 2024 22:06
2d82c8f
to
2615b63
Compare
ssbarnea
force-pushed
the
chore/nvm-to-asdf
branch
from
January 23, 2024 22:07
2615b63
to
138035f
Compare
ssbarnea
force-pushed
the
chore/nvm-to-asdf
branch
from
January 23, 2024 22:16
138035f
to
b1b4fee
Compare
ssbarnea
force-pushed
the
chore/nvm-to-asdf
branch
from
January 23, 2024 22:32
b1b4fee
to
b2ccdd3
Compare
ganeshrn
approved these changes
Jan 24, 2024
audgirka
approved these changes
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the used of
nvm
withasdf
, which is a newer, more generic, build tool management solution, one that can also be used to manage python versions and lots of other tools uses in the build chain.One extra benefit that we get from this is that we will be used the same versions of nodejs on CI and for local testing, as the tools does control this via the
.tools-versions
config file.As seen in the PR, from now on we will be using node 18 as default node version, as this the default node used by currently supported versions of vscode and also by extest.
We will also keep one job (test-node-lts) that will test with latest LTS version of node, as of today this is
20
. The goes of this is to keep our codebase ready for future bumping of node, once vscode and extest will switch to it.Please test this change locally, as this will validate that you have a working
asdf
installation. Runningtask test
should work if you configure it correctly.