Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore a webpack warning from vscode-languageserver-textdocument #1051

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Ignore a webpack warning from vscode-languageserver-textdocument #1051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b2bd222
Ignore a webpack warning from vscode-languageserver-textdocument
TamiTakamiya Jan 17, 2024
db944f3
chore: auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 17, 2024
d753eab
Update vscode version to match @types/vscode
TamiTakamiya Jan 17, 2024
721ec3f
Merge remote-tracking branch 'origin/TamiTakamiya/ignore-a-webpack-wa…
TamiTakamiya Jan 17, 2024
dd8c68c
Set PRETTIER_LEGACY_CLI=1 to see if it fix the prettier issue
TamiTakamiya Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ concurrency:

env:
FORCE_COLOR: "1" # make mocha output colorful
PRETTIER_LEGACY_CLI: "1" # https://github.com/prettier/prettier/issues/15832

# A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs:
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,7 @@
"//": "node version affects only development, it does not affect VS Code runtime",
"node": ">=16.0",
"npm": "\n\nERROR: Please use yarn instead of npm for this repository.!!!\n\n",
"vscode": "^1.71.0",
"vscode": "^1.85.0",
"yarn": ">=3.2.1"
},
"extensionDependencies": [
Expand Down
3 changes: 1 addition & 2 deletions src/utils/telemetryUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ import {
getRedHatService,
TelemetryService,
} from "@redhat-developer/vscode-redhat-telemetry/lib";
import { RedHatService } from '@redhat-developer/vscode-redhat-telemetry';

import { RedHatService } from "@redhat-developer/vscode-redhat-telemetry";

import { ExtensionContext } from "vscode";
import {
Expand Down
7 changes: 7 additions & 0 deletions webpack.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@ const config = {
__dirname: false, // leave the __dirname-behavior intact
},
plugins: [new WarningsToErrorsPlugin()],
ignoreWarnings: [
{
// https://github.com/microsoft/vscode-languageserver-node/issues/1355
message:
/require function is used in a way in which dependencies cannot be statically extracted/,
},
],
output: {
filename: (pathData: { chunk: { name: string } }) => {
return pathData.chunk.name === "client"
Expand Down
Loading