Test with min/max versions supported by extest #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshrn
requested changes
Mar 21, 2023
ganeshrn
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
As pointed out by @ssbarnea the current min and max versions of extest https://github.com/redhat-developer/vscode-extension-tester/blob/a429a6cf4a0662cb9fe512f1238696ed9c3fbbd6/src/extester.ts#L29 looks good for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As extest supports only a clear set of vscode versions, we aim to
match them, so we can move to newer version as soon they are
supported.
It should be noted that quite often extest needs changes in order
to properly test extensions with newer versions of vscode. This change
should make the testing outcome more predictable.