Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: PyAEDT now open the most recent stable version as default #5239

Merged
merged 21 commits into from
Oct 7, 2024

Conversation

Alberto-DM
Copy link
Contributor

@Alberto-DM Alberto-DM commented Oct 3, 2024

This PR changes the default behavior when version is not specified while PyAEDT opens Electronics Desktop.
Now, PyAEDT opens the most recent stable version installed on the system. This prevents pre-release versions from being opened by default, as they may still be unstable and not fully supported by PyAEDT.
Beta and pre-release versions can still be opened by explicitly specifying the version argument.
All methods regarding versioning have been now moved under the class AedtVersions.

Closes the issue #5225.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Alberto-DM Alberto-DM marked this pull request as draft October 3, 2024 14:35
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 85.21127% with 21 lines in your changes missing coverage. Please review.

Project coverage is 83.29%. Comparing base (3af0e49) to head (bc94576).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5239      +/-   ##
==========================================
+ Coverage   83.26%   83.29%   +0.02%     
==========================================
  Files         142      143       +1     
  Lines       58343    58439      +96     
==========================================
+ Hits        48581    48675      +94     
- Misses       9762     9764       +2     

@github-actions github-actions bot added the testing Anything related to testing label Oct 7, 2024
@Alberto-DM Alberto-DM marked this pull request as ready for review October 7, 2024 12:23
@Alberto-DM Alberto-DM merged commit 99b3187 into main Oct 7, 2024
67 of 73 checks passed
@Alberto-DM Alberto-DM deleted the open_stable_version branch October 7, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants