Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HLSMerger Plugin #118

Merged
merged 10 commits into from
Jan 12, 2025
Merged

Add HLSMerger Plugin #118

merged 10 commits into from
Jan 12, 2025

Conversation

burak-58
Copy link
Contributor

@burak-58 burak-58 commented Oct 6, 2024

@burak-58 burak-58 mentioned this pull request Oct 6, 2024
Closed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 6, 2024

Quality Gate Passed Quality Gate passed for 'Media Push Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 6, 2024

Quality Gate Passed Quality Gate passed for 'Filter Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mekya
mekya requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@mekya mekya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @burak-58,

Thank you for the implementation.

I need you to change somethings as I mention in the comments.

Regards
Oguz

HLSMergerPlugin/README.md Show resolved Hide resolved
HLSMergerPlugin/src/main/java/io/antmedia/rest/RestService.java Outdated Show resolved Hide resolved
HLSMergerPlugin/src/test/java/io/antmedia/plugin/HLSMergerPluginTest.java Outdated Show resolved Hide resolved
mekya
mekya requested changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@mekya mekya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @burak-58
I need further improvements in the code and there are some uncompleted conversations.

FYI

HLSMergerPlugin/src/main/java/io/antmedia/rest/HLSMergerRestService.java Show resolved Hide resolved
HLSMergerPlugin/src/main/java/io/antmedia/plugin/HLSMergerPlugin.java Outdated Show resolved Hide resolved
HLSMergerPlugin/src/main/java/io/antmedia/rest/HLSMergerRestService.java Outdated
@Path("/multi-resolution-stream/{file-name}")
@Produces(MediaType.APPLICATION_JSON)
@Consumes(MediaType.APPLICATION_JSON)
public Response start(@PathParam("file-name") String fileName, @Parameter(description = "Stream Id", required = true) String[] streamIds) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please return Result and give some more information when there is an error

HLSMergerPlugin/src/main/java/io/antmedia/plugin/HLSMergerPlugin.java Outdated Show resolved Hide resolved
HLSMergerPlugin/src/main/java/io/antmedia/plugin/HLSMergerPlugin.java Outdated

try (PrintWriter out = new PrintWriter(audioHLSFile)) {
out.println(content);
} catch (FileNotFoundException e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge the exceptions because if it fails here, it does not make sense to run the codes below

@mekya mekya changed the title add HLSMerger Plugin Add HLSMerger Plugin Jan 12, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'Media Push Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'Filter Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mekya mekya merged commit 62db992 into master Jan 12, 2025
5 checks passed
@mekya mekya deleted the hlsMergerPlugin branch January 12, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mekya mekya mekya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burak-58 @mekya