Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arbiter-core / arbiter-engine): broadcasters, halting, test sims #801

Merged
merged 21 commits into from
Jan 22, 2024

Conversation

Autoparallel
Copy link
Collaborator

@Autoparallel Autoparallel commented Jan 19, 2024

Give an overview of the tasks completed
Managed to switch over to using tokio::sync::broadcast as the broadcaster of choice in both arbiter-core and arbiter-agent which seemed to fix concurrency issues with agent behaviors. This gets both the issues below.

Link to issue(s) that this PR closes

** IN PROGRESS**
World::stop() is broken, however agents can halt their behavior processing by choice in definition of that behavior.
Replaced with #802

@Autoparallel Autoparallel marked this pull request as ready for review January 20, 2024 00:16
0xJepsen
0xJepsen previously approved these changes Jan 22, 2024
Copy link
Collaborator

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm into merging this. Nice work fighting this battle with the async demons

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 53 lines in your changes are missing coverage. Please review.

Comparison is base (7ecc57a) 53.29% compared to head (a6744b8) 56.48%.
Report is 47 commits behind head on main.

Files Patch % Lines
arbiter-engine/src/agent.rs 89.72% 15 Missing ⚠️
arbiter-engine/src/machine.rs 76.36% 13 Missing ⚠️
arbiter-engine/src/world.rs 85.39% 13 Missing ⚠️
arbiter-core/src/middleware/connection.rs 85.29% 5 Missing ⚠️
arbiter-core/src/data_collection.rs 95.12% 2 Missing ⚠️
arbiter-core/src/environment/mod.rs 81.81% 2 Missing ⚠️
arbiter-engine/src/messager.rs 94.28% 2 Missing ⚠️
arbiter-core/src/middleware/mod.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #801      +/-   ##
==========================================
+ Coverage   53.29%   56.48%   +3.19%     
==========================================
  Files          37       38       +1     
  Lines        7397     7637     +240     
==========================================
+ Hits         3942     4314     +372     
+ Misses       3455     3323     -132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xJepsen 0xJepsen merged commit e36f75c into main Jan 22, 2024
11 checks passed
@0xJepsen 0xJepsen deleted the arbiter-engine/world-agent-behaviors branch January 22, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants