-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(arbiter-core / arbiter-engine): broadcasters, halting, test sims #801
Conversation
But this is cleaned up quite a bit and is almost there.
This commit broke stuff!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm into merging this. Nice work fighting this battle with the async demons
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #801 +/- ##
==========================================
+ Coverage 53.29% 56.48% +3.19%
==========================================
Files 37 38 +1
Lines 7397 7637 +240
==========================================
+ Hits 3942 4314 +372
+ Misses 3455 3323 -132 ☔ View full report in Codecov by Sentry. |
Give an overview of the tasks completed
Managed to switch over to using
tokio::sync::broadcast
as the broadcaster of choice in botharbiter-core
andarbiter-agent
which seemed to fix concurrency issues with agent behaviors. This gets both the issues below.Link to issue(s) that this PR closes
World
drivingAgent
behaviors concurrently #788tokio::sync
orasync-broadcast
) inEnvironment.Socket
#756** IN PROGRESS**
World::stop()
is broken, however agents can halt their behavior processing by choice in definition of that behavior.Replaced with #802