Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: destroy custom label before render #4146

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix: destroy custom label before render #4146

merged 1 commit into from
Jan 10, 2024

Conversation

NewByVector
Copy link
Contributor

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added the PR(fix) :bug: Bug Fix label Jan 10, 2024
@x6-bot
Copy link
Contributor

x6-bot bot commented Jan 10, 2024

@NewByVector Please provide us with more info about this pull request.

@x6-bot x6-bot bot added needs-more-info pkg:x6 size/M Denotes a PR that changes 30-99 lines, ignoring generated files. PR: unreviewed PR does not have any reviews. labels Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (8169d42) 10.37% compared to head (be5a4a0) 10.37%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4146   +/-   ##
=======================================
  Coverage   10.37%   10.37%           
=======================================
  Files         180      180           
  Lines       10550    10550           
  Branches     2569     2569           
=======================================
  Hits         1095     1095           
  Misses       9366     9366           
  Partials       89       89           
Flag Coverage Δ
x6 10.37% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/x6/src/graph/options.ts 17.64% <ø> (ø)
packages/x6/src/view/edge.ts 1.12% <0.00%> (ø)

@NewByVector NewByVector merged commit 281209a into master Jan 10, 2024
19 checks passed
@NewByVector NewByVector deleted the fix/labels branch January 10, 2024 09:09
@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-more-info pkg:x6 PR(fix) :bug: Bug Fix PR: merged PR has merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant