Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Commit

Permalink
Use symmetrical quotation characters in error messages
Browse files Browse the repository at this point in the history
Symmetrical quoting looks better.

Thus s/`/'/

See '5.10 Quote Characters' in GNU Coding Standards:

https://www.gnu.org/prep/standards/standards.html#Quote-Characters

(cherry picked from commit 262e119)

[skip ci]
  • Loading branch information
fxlb committed Nov 16, 2023
1 parent 553ba27 commit 879d7ab
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGES
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ DayOfTheWeek, Month DD, YYYY / The Tcpdump Group
User interface:
Print the supported time stamp types (-J) to stdout instead of stderr.
Print the list of data link types (-L) to stdout instead of stderr.
Use symmetrical quotation characters in error messages.
Source code:
tcpdump: Fix a memory leak.
child_cleanup: reap as many child processes as possible.
Expand Down
6 changes: 3 additions & 3 deletions tcpdump.c
Original file line number Diff line number Diff line change
Expand Up @@ -1728,7 +1728,7 @@ main(int argc, char **argv)
if (nd_load_smi_module(optarg, ebuf, sizeof(ebuf)) == -1)
error("%s", ebuf);
} else {
(void)fprintf(stderr, "%s: ignoring option `-m %s' ",
(void)fprintf(stderr, "%s: ignoring option '-m %s' ",
program_name, optarg);
(void)fprintf(stderr, "(no libsmi support)\n");
}
Expand Down Expand Up @@ -1772,7 +1772,7 @@ main(int argc, char **argv)
else if (ascii_strcasecmp(optarg, "inout") == 0)
Qflag = PCAP_D_INOUT;
else
error("unknown capture direction `%s'", optarg);
error("unknown capture direction '%s'", optarg);
break;
#endif /* HAVE_PCAP_SETDIRECTION */

Expand Down Expand Up @@ -1838,7 +1838,7 @@ main(int argc, char **argv)
else if (ascii_strcasecmp(optarg, "domain") == 0)
ndo->ndo_packettype = PT_DOMAIN;
else
error("unknown packet type `%s'", optarg);
error("unknown packet type '%s'", optarg);
break;

case 'u':
Expand Down

0 comments on commit 879d7ab

Please sign in to comment.