Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduces log level for some chatty logs #5082

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

reduces log level for some chatty logs #5082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion server/base/src/main/java/org/apache/accumulo/server/conf/CheckCompactionConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ public static void validate(AccumuloConfiguration config, Level level)

Set<String> defaultService = Set.of(DEFAULT_COMPACTION_SERVICE_NAME);
if (servicesConfig.getPlanners().keySet().equals(defaultService)) {
log.warn("Only the default compaction service was created - {}", defaultService);
log.atLevel(level).log("Only the default compaction service was created - {}",
Copy link
Contributor

@ddanielr ddanielr Nov 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iirc, the original goal of this log message was to alert users that the compaction service might not have been properly created. However, if a custom service was never defined than this just logs endlessly.

Might be a good follow on to try and validate the servicesConfig planners vs what planner prefixes might be set in the properties? and only log if there's a difference?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have implementions for a ConditionalLogger. One deduplicates and the other escalates. If you only want to see the message once every N time units, then use the DeduplicatingLogger. If you want to see the message at level X once every N time units, and at level Y the remaining times, then use the EscalatingLogger.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good follow on to try and validate the servicesConfig planners vs what planner prefixes might be set in the properties? and only log if there's a difference?

Could this be accomplished by adding unit test for CompactionServicesConfig that verifies it fails/throws an exception under these conditions?

defaultService);
return;
}

Expand Down
6 changes: 3 additions & 3 deletions ...anager/src/main/java/org/apache/accumulo/manager/compaction/coordinator/QueueMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,15 +168,15 @@ public void update() {
CompactionJobQueues::getQueueCount)
.description(COMPACTOR_JOB_PRIORITY_QUEUES.getDescription()).register(localRegistry);
}
LOG.debug("update - cjq queues: {}", compactionJobQueues.getQueueIds());
LOG.trace("update - cjq queues: {}", compactionJobQueues.getQueueIds());

Set<CompactorGroupId> definedQueues = compactionJobQueues.getQueueIds();
LOG.debug("update - defined queues: {}", definedQueues);
LOG.trace("update - defined queues: {}", definedQueues);

// Copy the keySet into a new Set so that changes to perQueueMetrics
// don't affect the collection
Set<CompactorGroupId> queuesWithMetrics = new HashSet<>(perQueueMetrics.keySet());
LOG.debug("update - queues with metrics: {}", queuesWithMetrics);
LOG.trace("update - queues with metrics: {}", queuesWithMetrics);

SetView<CompactorGroupId> queuesWithoutMetrics =
Sets.difference(definedQueues, queuesWithMetrics);
Expand Down