Resets compaction queue max size when config changes #5278
+92
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the manager to reset the max size on compaction queues when config changes. In the case where the current data size of the queue exceeds the new configured size the lowest priority jobs are dropped until the size is acceptable.
dlmarion
reviewed
Jan 24, 2025
| @@ -294,10 +294,23 @@ protected void startInternalStateCleaner(ScheduledThreadPoolExecutor schedExecut | |||
| ThreadPools.watchNonCriticalScheduledTask(future); | |||
| } | |||
|
|
|||
| protected void startConfigMonitor(ScheduledThreadPoolExecutor schedExecutor) { | |||
| ScheduledFuture<?> future = | |||
| schedExecutor.scheduleWithFixedDelay(this::cleanUpInternalState, 0, 1, TimeUnit.MINUTES); | |||
There was a problem hiding this comment.
Should this call checkForConfigChanges instead of cleanUpInternalState?
There was a problem hiding this comment.
ha, yeah it should good catch. I copied and pasted and changed a few things, but missed that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the manager to reset the max size on compaction queues when config changes. In the case where the current data size of the queue exceeds the new configured size the lowest priority jobs are dropped until the size is acceptable.