fix: etcd compact err【do not merge me! only for discussion】 #11149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nic-chen
reviewed
Apr 12, 2024
| if not dir_res then | ||
| if err == "compacted" then |
There was a problem hiding this comment.
please don't remove these codes, we should keep them.
|
@nic-chen Readded the error handling for compact err |
membphis
changed the title
nic-chen
reviewed
Apr 12, 2024
apisix/core/config_etcd.lua
Outdated
Comment on lines
348
to
355
| log.info("updating prev_index from "..self.prev_index.." to "..rev ) | ||
| if rev then | ||
| if rev == self.prev_index then | ||
| goto fail | ||
| end | ||
| self.prev_index = rev | ||
| end | ||
| goto waitdir |
There was a problem hiding this comment.
how about the change?
Suggested change
| log.info("updating prev_index from "..self.prev_index.." to "..rev ) | |
| if rev then | |
| if rev == self.prev_index then | |
| goto fail | |
| end | |
| self.prev_index = rev | |
| end | |
| goto waitdir | |
| log.info("updating prev_index from "..self.prev_index.." to "..rev ) | |
| self:upgrade_version(rev) |
nic-chen
reviewed
Apr 12, 2024
apisix/core/config_etcd.lua
Outdated
| if err == "compacted" then | ||
| self.need_reload = true | ||
| log.warn("waitdir [", self.key, "] err: ", err, | ||
| ", will read the configuration again via readdir") | ||
| return false | ||
| goto fail |
There was a problem hiding this comment.
we don't need to change the workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Checklist