Skip to content

Commit

Permalink
Fix IPv4-only parsing tests, proposed as git pull req #15 by manusfre…
Browse files Browse the repository at this point in the history
…edom.

git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1855867 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
wrowe committed Mar 19, 2019
1 parent e304d7e commit 80ae7b6
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion test/testipsub.c
Original file line number Diff line number Diff line change
Expand Up @@ -179,19 +179,23 @@ static void test_parse_addr_port(abts_case *tc, void *data)
,{ "www.example.com:8080", APR_SUCCESS, "www.example.com", NULL, 8080 }
,{ "w:1", APR_SUCCESS, "w", NULL, 1 }
,{ "127.0.0.1:80", APR_SUCCESS, "127.0.0.1", NULL, 80 }
,{ "8080", APR_SUCCESS, NULL, NULL, 8080 } /* API doc has this case */
#if APR_HAVE_IPV6
,{ "[::]:80", APR_SUCCESS, "::", NULL, 80 }
,{ "[::%eth0]:80", APR_SUCCESS, "::", "eth0", 80 }
,{ "[::%eth0]", APR_SUCCESS, "::", "eth0", 0 }
,{ "8080", APR_SUCCESS, NULL, NULL, 8080 } /* API doc has this case */
#endif

/* Failure cases */
,{ "localhost:999999", APR_EINVAL, NULL, NULL, 0 }
,{ "localhost:0", APR_EINVAL, NULL, NULL, 0 }
#if APR_HAVE_IPV6
,{ "[abc]", APR_EINVAL, NULL, NULL, 0 }
,{ "[::]z:80", APR_EINVAL, NULL, NULL, 0 }
,{ "[:::80", APR_EINVAL, NULL, NULL, 0 }
,{ "[zzzz]:80", APR_EINVAL, NULL, NULL, 0 }
,{ "[::%]:80", APR_EINVAL, NULL, NULL, 0 }
#endif
/* ,{ "127.0.0.1:80x", APR_EINVAL, NULL, NULL, 0 } <- should fail, doesn't */
/* ,{ "127.0.0.1x:80", APR_EINVAL, NULL, NULL, 0 } <- maybe should fail?, doesn't */
/* ,{ "localhost:-1", APR_EINVAL, NULL, NULL, 0 } <- should fail, doesn't */
Expand Down

0 comments on commit 80ae7b6

Please sign in to comment.