Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not publish javadoc jar when exportJavadoc disabled #33560

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Jan 10, 2025

It is found that shadow jars with exportJavadoc set to false still publishes an empty javadoc jar to maven repository. This reduces release overhead by 100+ artifacts

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Jan 10, 2025
@Abacn
Copy link
Contributor Author

Abacn commented Jan 10, 2025

tested with an example task: "./gradlew :sdks:java:extensions:combiners:publishToMavenLocal -Ppublishing"

before, a javadoc jar build; after, javadoc jar not build.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn
Copy link
Contributor Author

Abacn commented Jan 10, 2025

local environment test failed post action, github flakiness, unrelated to this change

@Abacn
Copy link
Contributor Author

Abacn commented Jan 10, 2025

R: @damccorm

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@damccorm
Copy link
Contributor

Thanks!

@Abacn Abacn merged commit 0ea0fb4 into apache:master Jan 10, 2025
16 of 17 checks passed
@Abacn Abacn deleted the javadocjar branch January 10, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants