[DSIP-27][Task Plugin] Some improvements of JAVA task plugin #16542
Conversation
ailiujiarui
requested review from
songjianet,
Amy0104,
caishunfeng,
SbloodyS,
zhuangchong and
Gallardot
as code owners
SbloodyS
changed the title
SbloodyS
added
first time contributor
SbloodyS
changed the title
ailiujiarui
force-pushed
the
dev
branch
2 times, most recently
from
9c45ca0 to
6d16b63
Compare
ailiujiarui
force-pushed
the
dev
branch
3 times, most recently
from
37b92ed to
151bdfe
Compare
Please check if additional explanation is needed
|
...ler-task-java/src/main/java/org/apache/dolphinscheduler/plugin/task/java/JavaParameters.java
Show resolved
Hide resolved
The |
I've encountered a similar issue before as well. What worked for me was rerunning the entire test from the beginning, and that allowed it to pass successfully. |
You should check the error message of |
Through testing, it was found that unstable file uploads—often resulting in failed uploads—and frequently missing resource file selections in the Resources panel are caused by the component's loading process. Specifically, webwait only detects the presence of DOM elements without ensuring that their child elements have fully loaded. In other words, the code continues to execute before the page is completely rendered, leading to these issues. To address this problem, I implemented thread.sleep to wait for the complete loading. This method is currently stable and effective. I also considered other approaches, but none could effectively and concisely replace it. |
...ler-task-java/src/main/java/org/apache/dolphinscheduler/plugin/task/java/JavaParameters.java
Outdated
Show resolved
Hide resolved
...scheduler-task-java/src/main/java/org/apache/dolphinscheduler/plugin/task/java/JavaTask.java
Outdated
Show resolved
Hide resolved
|
Requires Approval @ruanwenjun |
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
|
Awesome work, congrats on your first merged pull request! |
|
Merged into dev, will be released at 3.3.0, thanks for your PR, helps a lot. @ailiujiarui |
Purpose of the pull request
Update the Java task plugin
close:#15819
Brief change log
Deprecate write java code in JAVA task
Rename the JAR to FATJAR
Only the displayed name has been modified, the functionality remains unchanged.
Add the new type NORMALJAR
Allow users to upload normal type of jar files, which require external libraries to run properly. Users do not need to package all libraries and runtime files into a fat jar each time, making the submission of jar files more flexible and convenient.
Update the tests
Update tests about JAVA type and add the test of JAR type. Like JavaTaskTest and workflowJavaTaskE2ETest.
For the JavaE2Etest, the fat.java,normal1.java,normal2.java,have been added e2e-case/resources/docker/java-task. These three Java files will be compiled and packaged into fat.jar, normal1.jar, and normal2.jar. fat.jar is for the FAT_JAR type. The normal1.jar and normal2.jar are for the NORMAL_JAR type.
Update the Javadoc comment
type of FATJAR
type of NORMALJAR
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md