[DSIP-73] Add dolphinscheduler-task-executor module to unify the task execution logic #16790
Conversation
ruanwenjun
requested review from
caishunfeng,
SbloodyS and
Gallardot
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
ruanwenjun
force-pushed
the
dev_wenjun_implementLogicTaskSupportPasueKill
branch
from
d3942d4 to
9abfb14
Compare
ruanwenjun
force-pushed
the
dev_wenjun_implementLogicTaskSupportPasueKill
branch
4 times, most recently
from
ac13593 to
e3f5a95
Compare
ruanwenjun
force-pushed
the
dev_wenjun_implementLogicTaskSupportPasueKill
branch
14 times, most recently
from
2c71278 to
2830a68
Compare
ruanwenjun
force-pushed
the
dev_wenjun_implementLogicTaskSupportPasueKill
branch
from
a8c7311 to
d1fa92b
Compare
ruanwenjun
force-pushed
the
dev_wenjun_implementLogicTaskSupportPasueKill
branch
5 times, most recently
from
95ea2da to
2f72848
Compare
...g/apache/dolphinscheduler/server/master/engine/executor/plugin/dynamic/DynamicLogicTask.java
Show resolved
Hide resolved
...org/apache/dolphinscheduler/server/master/engine/system/event/GlobalMasterFailoverEvent.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/dolphinscheduler/server/master/engine/WorkflowEventBusFireWorkers.java
Outdated
Show resolved
Hide resolved
ruanwenjun
force-pushed
the
dev_wenjun_implementLogicTaskSupportPasueKill
branch
12 times, most recently
from
c053789 to
0fcf9ab
Compare
ruanwenjun
force-pushed
the
dev_wenjun_implementLogicTaskSupportPasueKill
branch
from
0fcf9ab to
1e2eaaa
Compare
…dTaskExecutorContainer
|
...nscheduler/server/master/engine/executor/plugin/dynamic/DynamicAsyncTaskExecuteFunction.java
Show resolved
Hide resolved
...e/dolphinscheduler/server/master/engine/task/client/PhysicalTaskExecutorClientDelegator.java
Show resolved
Hide resolved
| /** | ||
| * The task instance's runtime context changed. | ||
| */ | ||
| RUNTIME_CONTEXT_CHANGED, |
There was a problem hiding this comment.
Why need to add this event type? The runtime context should be check in running event or finish event.
There was a problem hiding this comment.
Import a new event type here can avoid we have multiple event schema for an event type. This event type represent the task runtime context changed, will not affect the state, if we use running event and finish event, we need to add runtime context info into these events, once runtime context changed, we will need to change these events.
And it's hard to explain why some running events have runtime context but some not.
So split the runtime context to a single event type can avoid these, this event type doesn't affect the lifecycle of a task.
Purpose of the pull request
close #16619
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md