Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Fix JdbcRegistryTestCase might failed due to purge dead clients interval is too small #16894

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Dec 12, 2024

Purpose of the pull request

  • Use session timeout as the purge interval.
  • Close the NettyServerChannel to unbind the port.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun self-assigned this Dec 12, 2024
@ruanwenjun ruanwenjun added this to the 3.3.0 milestone Dec 12, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixJdbcRegistryInUT branch 6 times, most recently from cca12fd to 871a0a5 Compare December 12, 2024 11:56
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixJdbcRegistryInUT branch 2 times, most recently from 648b42c to 1575593 Compare December 12, 2024 14:31
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixJdbcRegistryInUT branch from 1575593 to e6c3023 Compare December 12, 2024 14:32
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
59.0% Coverage on New Code (required ≥ 60%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit f57acab into apache:dev Dec 13, 2024
69 of 70 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixJdbcRegistryInUT branch December 13, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants