Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test step add codenarc and doc site build #241

Merged

Conversation

jonnybot0
Copy link
Contributor

This makes the base test step cover the same ground as the CircleCI build by adding the ci property and using check, not just test. The main difference is that this will run CodeNarc and copy reports from submodules into the root directory.

It seemed reasonable to me to run these all in the same step.

@paulk-asert
Copy link
Contributor

You should be able to delete style-check.yml. At the start, build and test was failing, so I just wanted the codenarc checks to be green - but fine to run them all together.

@paulk-asert paulk-asert merged commit 4802fed into apache:master Dec 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants