Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python version 3.13 to test matrix. #1377

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JE-Chen
Copy link
Contributor

@JE-Chen JE-Chen commented Nov 26, 2024

Fixes #1372
Add Python version 3.13 to matrix.

@JE-Chen
Copy link
Contributor Author

JE-Chen commented Nov 26, 2024

Python Rust binding maximum supported version (3.12)

error: the configured Python interpreter version (3.13) is newer than PyO3's maximum supported version (3.12)

@Fokko
Copy link
Contributor

Fokko commented Nov 26, 2024

@JE-Chen Thanks for checking. It looks like Py3O is already at 3.13: PyO3/pyo3#4636 I was hoping that maybe bumping the Poetry build might fix it #1379. Could you rebase? Otherwise we have to track which dependency is still locked at this older version of Py3O.

@JE-Chen
Copy link
Contributor Author

JE-Chen commented Nov 27, 2024

Done

@JE-Chen
Copy link
Contributor Author

JE-Chen commented Nov 27, 2024

Same error.

error: the configured Python interpreter version (3.13) is newer than PyO3's maximum supported version (3.12)

@JE-Chen
Copy link
Contributor Author

JE-Chen commented Nov 27, 2024

Currently, we are using pyo3 v0.20.3. I think only versions of pyo3 v0.21 or newer support Python 3.13.
Some dependencies require pyo3 v0.20.3, but I don't find pyo3 listed in the Poetry requirements.

@Fokko
Copy link
Contributor

Fokko commented Dec 20, 2024

@JE-Chen I think it pulls pyo3 in when it can't find pre-build wheels for a combination of the Python version and architecture.

@Fokko
Copy link
Contributor

Fokko commented Dec 20, 2024

  at ~/.local/lib/python3.10/site-packages/poetry/installation/chef.py:164 in _prepare
      160│ 
      161│                 error = ChefBuildError("\n\n".join(message_parts))
      162│ 
      163│             if error is not None:
    → 164│                 raise error from None
      165│ 
      166│             return path
      167│ 
      168│     def _prepare_sdist(self, archive: Path, destination: Path | None = None) -> Path:

Note: This error originates from the build backend, and is likely not a problem with poetry but with cramjam (2.8.3) not supporting PEP 517 builds. You can verify this by running 'pip wheel --no-cache-dir --use-pep517 "cramjam (==2.8.3)"'.

Looks like we're still pinning on an older version of cramjam, as 2.9.1 is out already: https://pypi.org/project/cramjam/

@Fokko
Copy link
Contributor

Fokko commented Jan 15, 2025

Fixing conflicts to see where we are with 3.13 :)

@kevinjqliu kevinjqliu force-pushed the test_matrix branch 2 times, most recently from 8bb7745 to 7a78748 Compare January 19, 2025 20:44
@kevinjqliu
Copy link
Contributor

Blocked on Ray 3.13 ray-project/ray#49738

We can run poetry update after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python 3.13 to the test matrix
3 participants