Improve LocationProvider unit tests
#1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaheshwar-pltr
force-pushed
the
object-storage-better-tests
branch
from
216e9a9 to
a88a484
Compare
smaheshwar-pltr
commented
Jan 12, 2025
Comment on lines
+100
to
+101
| # key AND the data file name are used as the hash input. This matches Java behaviour; the hash below is what the | ||
| # Java implementation produces for this input too. |
There was a problem hiding this comment.
I've verified this. There's no test of this in https://github.com/apache/iceberg/blob/main/core/src/test/java/org/apache/iceberg/TestLocationProvider.java that we can take the hash from sadly.
I like testing this here. It's not obvious that both partition key and file name are used as hash input.
kevinjqliu
approved these changes
Jan 12, 2025
|
Thanks for the follow up @smaheshwar-pltr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1509 (comment) for context/motivation.
This PR better highlights location provider behaviour in the presence of partitions in unit tests. It tests related behaviour more carefully - e.g. it tests that partition values and entropy included in paths when object storage location provision is used (without partitioned paths disabled) that can be confusing. It also tests the injected hash itself in this scenario because it's the hash method of both the file name and the partition key - this matches the Java implementation and I've tested that the Java code produces the same output for this case (https://github.com/apache/iceberg/blob/main/core/src/test/java/org/apache/iceberg/TestLocationProvider.java has no tests for this as of now).
@kevinjqliu maybe, mind taking a look?