ADLS: Support Vended Credentials #1520
Merged
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First version with `Fsspec`. Will check with PyArrow tomorrow, but that one seems to be lacking the SAS token: https://arrow.apache.org/docs/cpp/api/filesystem.html#azure-filesystem Closes apache#1146
|
I believe support for SAS token was added to the Arrow azure filesystem, but I don't think it has been released yet: apache/arrow#45021 looks like arrow 19 release may be in progress as we speak from snooping around on github. |
|
depends on #1526 |
kevinjqliu
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
LGTM since this was tested against an actual ADLS.
Linking the Arrow PR which added support for SAS_TOKEN, apache/arrow#45021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First version with
Fsspec.Will check with PyArrow tomorrow, but that one seems to be lacking the SAS token:SAS token has been added in 19.0.0 🥳https://arrow.apache.org/docs/cpp/api/filesystem.html#azure-filesystem
Tested against an actual ADLS.
Closes #1146