Fix literal predicate equality check #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Oct 22, 2023
| @@ -701,7 +701,7 @@ def bind(self, schema: Schema, case_sensitive: bool = True) -> BoundLiteralPredi | |||
|
|
|||
| def __eq__(self, other: Any) -> bool: | |||
| """Return the equality of two instances of the LiteralPredicate class.""" | |||
| if isinstance(other, LiteralPredicate): | |||
| if isinstance(other, self.__class__): | |||
There was a problem hiding this comment.
This fix is for the LiteralPredicate, but there are more:
- Line 367 should also use
self.__class__forIsNull,IsNaNetc. - Can you add
self.__class__to theSetPredicateon line 534. - The
__eq__ofNotInon line 667 can go (Indoesn't have one either).
There was a problem hiding this comment.
Raised a PR danielcweeks#1 to get these fixed :)
Fokko
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The equality check was not checking to see if they were the same predicate so:
would evaluate
StartsWith == NotStartsWithastrue(or any combination of LiteralPredicate)