DROOLS-7573 - add parameter for h2vm/infinispan store #268
Conversation
| configureServicePriorities(); | ||
| }else { // assuming infinispan is the default module | ||
| System.setProperty(DROOLS_RELIABILITY_MODULE_TEST, "INFINISPAN"); | ||
| configureServicePriorities(); |
There was a problem hiding this comment.
Please move this configureServicePriorities(); (for infinispan) to line-110. `configureServicePriorities() triggers storage initialization, so it should be called after all system properties are set.
| public enum Module { | ||
| INFINISPAN, | ||
| H2MVSTORE | ||
| } |
There was a problem hiding this comment.
At first, I thought that Module is a good idea. But then we have to deal with unexpected combinations like "H2MVSTORE" + "REMOTE", or "H2MVSTORE" + "REMOTEPROTO".
If you run
java -jar target/drools-benchmarks-reliability.jar -jvmArgs "-Xms4g -Xmx4g" -foe true -wi 0 -i 1 -f 1 org.drools.benchmarks.reliability.InsertAndFireBenchmark
You will hit a failure with such a combination.
Probably it's better to use only Mode as a benchmark parameter. You may still use Module for internal code writing convenience (for example, Mode can have Module). So add "H2MVSTORE" to Mode. Maybe also it's better to rename like "EMBEDDED" to "INFINISPAN_EMBEDDED" and so on (but infinispanStorageMode values shouldn't be changed , because it's used for INFINISPAN_STORAGE_MODE)
Let me know if it's not clear for you.
There was a problem hiding this comment.
yes, I understand. I will make the changes needed.
|
So overall, I recommend to run to check if benchmarks can run with all params combinations. |
I run the above with all benchmarks, found a problem with InsertOnlyBenchmark and solved it by moving the call to configureServicePriorities() before attempting to instantiate the InfinispanStorageManager (class AbstractReliabilityBenchmark, method setupEnvironment() ). |
DROOLS-7573