JAMES-2586 Postgresql implementation: ready for master #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed by JAMES-2586 Small codestyle refactorings.
…lict Otherwise, we could retry on other fatal errors like: io.r2dbc.postgresql.ExceptionFactory$PostgresqlBadGrammarException: column "domain" of relation "mailbox" already exists.
…olicy before alter the table
This prevents data loss.
Co-authored-by: Quan Tran <[email protected]>
Co-authored-by: Quan Tran <[email protected]>
…ostgres table Would be useful in case jOOQ DSL does not provide support for some queries e.g. create an EXCLUDE constraint.
Merge a few PRs parallel led to this.
Again, an issue because of merging PRs in parallel.
While not needed now this extra field would significantly ease a future JMAP Sieve implementation and avoid a migration.
…-cli GIVEN I run james-cli in kubernetes THEN the pod crashes and reboots Because the james-cli runs JVM it catches the environment variables set by James. As such it always pretouch 3GB of RAM. When added to memory consumed by James it exceeds the limit and pod get's OOM-killed.
- Ref commit: 829a63f [IMPROVEMENT] JMAP use search index relevance as default sort
…Supported - TODO - Wait to adapt James-3945 to Postgres Ref commit: 81b61ed
- Fix java.util.ConcurrentModificationException - Fix test InMemoryUploadRepositoryTest
…some test class - The RLS PostgresExtension for test case that use without domain part don't make sense
…ome methods & introduce eager fetch mode
This reverts commit 194832f.
Co-authored-by: hung phan <[email protected]>
…rators if configured
Arsnael
changed the title
5 tasks
vttranlina
reviewed
Jan 7, 2025
Excellent work, in my opinion |
hungphan227
approved these changes
Jan 8, 2025
j-hellenberg
reviewed
Jan 8, 2025
Nobody do! Hopefully it was built by many smaller PR against the |
quantranhong1999
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the final work regarding postgresql implementation with James.
Please James community help us reviewing, commenting, approving if you wish to see this work being officially merged into the main branch of the project!
Note for the team: Last two commits were added to fix the build after rebase on latest master.