Rename BaseRequest#unmodifiable to copyToImmutable and add doc #2037
+17
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
reviewed
Jan 11, 2025
| * @param source the source collection to create an immutable copy from | ||
| * @param <T> the type of elements in the collection | ||
| * @return an unmodifiable view of the collection, or an empty list if the input is null or empty | ||
| * @throws NullPointerException if the collection contains null elements |
There was a problem hiding this comment.
Why do we do this? In general, lists with null elements are OK, though they might be wrong in a specific case. However if null elements are wrong in the specific case I'd expect the source list to already have checked that.
There was a problem hiding this comment.
It's just a side effect of using List.copyOf(). The behavior thus surfaces to this helper methods and the javadoc mentions it.
There was a problem hiding this comment.
In general, non null elements in list are a burden. Unless there's a specific semantic associated with a null value, I'd rather forbid those. For example if you want to resolve a list of artifacts, passing null values makes absolutely no sense to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.