HDDS-11345. Add metrics specific tests for reconciliation tasks. #7732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errose28
reviewed
Jan 22, 2025
There was a problem hiding this comment.
Thanks for adding the test @aswinshakil. Can we move this so the tests for reconciliation tasks are in their own test method within TestReplicationSupervisor? We can throw one into the mix in testMultipleReplication since it is already there, but that method is already testing too many things at once and it is hard to follow the individual things being checked.
errose28
reviewed
Jan 23, 2025
...er-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/ContainerLogger.java
Outdated
Show resolved
Hide resolved
...tainer-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java
Outdated
Show resolved
Hide resolved
...oop/ozone/container/common/statemachine/commandhandler/ReconcileContainerCommandHandler.java
Show resolved
Hide resolved
...ozone/container/common/statemachine/commandhandler/TestReconcileContainerCommandHandler.java
Outdated
Show resolved
Hide resolved
...ozone/container/common/statemachine/commandhandler/TestReconcileContainerCommandHandler.java
Show resolved
Hide resolved
...e/src/test/java/org/apache/hadoop/ozone/container/replication/TestReplicationSupervisor.java
Show resolved
Hide resolved
|
We need #7699 in our branch to fix acceptance tests |
aswinshakil
force-pushed
the
HDDS-11345
branch
from
5f43251 to
6fe3bdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#7140 Added a framework to add metrics for any
AbstractReplicationTask. This adds all the necessary metrics required for container reconciliation task(ReconcileContainerTask). This JIRA aims to add tests for these metrics.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11345
How was this patch tested?
Added unit tests.