Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SANTUARIO-611] Add support of ECDSA with SHA3 algorithms #302

Merged

Conversation

jrihtarsic
Copy link
Contributor

Added support for ECDSA SHA3 signatures:

For details see the ticker: SANTUARIO-611

Copy link
Member

@seanjmullan seanjmullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. It would be nice to also include a test for these algorithms using the javax.xml.crypto APIs.

@jrihtarsic
Copy link
Contributor Author

Sure, I added them now (I should already know this by now :) )
For the future tests I created an abstract class XMLSignatureAbstract with methods

doSignWithJcpApi
assertValidSignatureWithJcpApi

I updated the test class XMLSignatureEdDSATest with the new method
And when this PR will be merged I can update the test XMLSignatureBrainpoolTest in the PR #298

Copy link
Member

@seanjmullan seanjmullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the test restructuring.

@coheigea can you also review this PR?

@coheigea coheigea merged commit e150c20 into apache:main Apr 8, 2024
3 checks passed
coheigea pushed a commit that referenced this pull request Apr 8, 2024
* [SANTUARIO-611] Add support of ECDSA with SHA3 algorithms

* [SANTUARIO-611] update tests using javax.xml.crypto APIs.

---------

Co-authored-by: RIHTARSIC Joze <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants