[Fix][Connector-V2] User selects csv string pattern #8572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
reviewed
Jan 23, 2025
...atunnel-format-csv/src/main/java/org/apache/seatunnel/format/csv/CsvSerializationSchema.java
Outdated
Show resolved
Hide resolved
Hisoka-X
reviewed
Jan 23, 2025
...atunnel-format-csv/src/main/java/org/apache/seatunnel/format/csv/CsvSerializationSchema.java
Outdated
Show resolved
Hide resolved
Hisoka-X
reviewed
Jan 23, 2025
| @@ -119,6 +119,7 @@ If write to `csv`, `text` file type, All column will be string. | |||
| | common-options | object | no | - | | | |||
| | max_rows_in_memory | int | no | - | Only used when file_format is excel. | | |||
| | sheet_name | string | no | Sheet${Random number} | Only used when file_format is excel. | | |||
| | csv_string_quote_mode | string | no | MINIMAL | Only used when file_format is csv. | | |||
There was a problem hiding this comment.
Suggested change
| | csv_string_quote_mode | string | no | MINIMAL | Only used when file_format is csv. | | |
| | csv_string_quote_mode | enum | no | MINIMAL | Only used when file_format is csv. | |
Comment on lines
+517
to
+531
| - [BugFix] Fixed the following bugs that failed to write data to | ||
| files ([3258](https://github.com/apache/seatunnel/pull/3258)) | ||
| - When field from upstream is null it will throw NullPointerException | ||
| - Sink columns mapping failed | ||
| - When restore writer from states getting transaction directly failed | ||
| - [Feature] Support S3A protocol ([3632](https://github.com/apache/seatunnel/pull/3632)) | ||
| - Allow user to add additional hadoop-s3 parameters | ||
| - Allow the use of the s3a protocol | ||
| - Decouple hadoop-aws dependencies | ||
| - Allow user to add additional hadoop-s3 parameters | ||
| - Allow the use of the s3a protocol | ||
| - Decouple hadoop-aws dependencies | ||
| - [Improve] Support setting batch size for every file ([3625](https://github.com/apache/seatunnel/pull/3625)) | ||
| - [Feature]Set S3 AK to optional ([3688](https://github.com/apache/seatunnel/pull/)) | ||
|
|
||
| ### Next version | ||
|
|
||
| - [Improve] Support file compress ([3899](https://github.com/apache/seatunnel/pull/3899)) | ||
| - [Improve] Support file compress ([3899](https://github.com/apache/seatunnel/pull/3899)) |
| @@ -63,6 +63,7 @@ | |||
| | kerberos_keytab_path | string | 否 | - | kerberos 的 keytab 路径 | | |||
| | compress_codec | string | 否 | none | 压缩编解码器 | | |||
| | common-options | object | 否 | - | 接收器插件通用参数，请参阅 [接收器通用选项](../sink-common-options.md) 了解详情 | | |||
| | csv_string_quote_mode | string | 否 | MINIMAL | 仅在文件格式为 CSV 时使用。 | | |||
| .seaTunnelRowType(seaTunnelRowType) | ||
| .dateTimeFormatter(Formatter.YYYY_MM_DD_HH_MM_SS_SSSSSS) | ||
| .delimiter(",") | ||
| .quoteMode(CsvStringQuoteMode.ALL) |
There was a problem hiding this comment.
Please test other option value too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
User selects csv string pattern
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.