Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uninitialized values #330

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

SeverinDiederichs
Copy link
Collaborator

@SeverinDiederichs SeverinDiederichs commented Jan 9, 2025

Unfortunately #324 missed to add the initialization of the new component of numIALeft which led to non-reproducible results as soon the the circular buffer got around, found in a long discussion with @hahnjo.

To Do:

  • general physics validation
  • physics validation for alllayers, regions, noregions
  • ensure reproducibility in ttbar events

Validation:
setTrackInAllRegions:
Screenshot from 2025-01-09 14-42-21

alllayers:
Screenshot from 2025-01-09 16-29-33

regions:
Screenshot from 2025-01-09 16-30-09

noregions
Screenshot from 2025-01-09 16-30-36

@phsft-bot
Copy link

Can one of the admins verify this patch?

@agheata agheata merged commit 9697480 into apt-sim:master Jan 9, 2025
2 checks passed
@SeverinDiederichs SeverinDiederichs deleted the fix_uninitialized_values branch January 9, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants