ApplyCuts (rebase) #334
Merged
ApplyCuts (rebase) #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
SeverinDiederichs
force-pushed
the
apply_cut_rebase
branch
from
74a67d7 to
c5d34c3
Compare
agheata
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
ApplyCutsused by G4 in AdePT. It is based and supersedes PR #317. TheApplyCutsvalue is read from Geant4 and can be toggled via/process/em/applyCuts trueNote that currently the positron cut is not yet available in G4HepEm (but will be shortly), and we use just use the electron cut. This will be fixed soon.
The restructuring of the scoring is now fully functional.
The run time shows that the
ApplyCutsworks as intended and accelerates the simulation. Since the scoring was also effected, the table also shows the results withApplyCuts = false, which shows just the new scoring implementationAdditionally, the update of the time for gammas was incorrect (as it would have been skipped if a boundary was hit), this is also fixed.
The physics validation looks really good using the
ApplyCutsboth in G4 and AdePT (for 10^7 primaries, note the smaller y axis for the errors):To Do: